dongeforever commented on issue #543: When first Store message mappedFile is 
null ,Concurrency create will more one mappedFile
URL: https://github.com/apache/rocketmq/pull/543#issuecomment-439260539
 
 
   @jiangxinlingdu The code is better in the lock. But currently, the following 
code:
   `
   if (null == mappedFile || mappedFile.isFull()) {
                   mappedFile = this.mappedFileQueue.getLastMappedFile(0); // 
Mark: NewFile may be cause noise
               }
   `
   will prevent creating duplicated mapped file. So it has no defects finally.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to