jovan-wong commented on a change in pull request #23: integration Googletest
URL: https://github.com/apache/rocketmq-client-cpp/pull/23#discussion_r239999847
##########
File path: build.sh
##########
@@ -231,29 +249,92 @@ function BuildBoost()
fi
}
-function BuildRocketMQClient()
+BuildRocketMQClient()
{
cd ${build_dir}
cmake ..
- make
+ make -j8
if [ $? -ne 0 ];then
exit 1
fi
#sudo make install
PackageRocketMQStatic
}
-function PackageRocketMQStatic()
+BuildGoogleTest()
+{
+ if [ $need_build_test -eq 0 ];then
+ echo "no need google test lib"
+ return 0
+ fi
+
+ if [ -e ./bin/lib/libgtest.a ]
+ then
+ echo "libgteest already exist no need build test"
+ return 0
+ fi
+
+ cd ${down_dir}
Review comment:
how about using `pushd ${down_dir}` instead of `cd ${down_dir}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
