Hellojungle commented on a change in pull request #12: [WIP]More Configurable
fields and mores
URL: https://github.com/apache/rocketmq-client-go/pull/12#discussion_r241655906
##########
File path: core/producer.go
##########
@@ -59,21 +60,85 @@ func (status SendStatus) String() string {
}
}
-func newDefaultProducer(config *ProducerConfig) *defaultProducer {
+func newDefaultProducer(config *ProducerConfig) (*defaultProducer, error) {
+ if config.GroupID == "" {
Review comment:
Maybe judge the config with nil?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
