snicoll commented on a change in pull request #4: 修复当ObjectMapper 的 Bean
已存在时候，不叫rocketMQMessageObjectMapper，无法启动
URL: https://github.com/apache/rocketmq-spring/pull/4#discussion_r241679253
##########
File path:
rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/config/RocketMQAutoConfiguration.java
##########
@@ -66,7 +66,7 @@ public DefaultMQProducer
defaultMQProducer(RocketMQProperties rocketMQProperties
@Bean
@ConditionalOnClass(name = "com.fasterxml.jackson.databind.ObjectMapper")
- @ConditionalOnMissingBean(ObjectMapper.class)
+ @ConditionalOnMissingBean(name = "rocketMQMessageObjectMapper")
Review comment:
@walking98 I don't know if you're asking me. The issue has non english
description so I didn't get it.
Assuming you're asking me, what I am trying to ask is why do you need a
dedicated `ObjectMapper`? If you do you can't create it like that otherwise
you're going to switch off the one Spring Boot auto-configures by default
depending on the ordering of the auto-configurations. If you could clarify why
this exists in the first place, I could probably help and recommend something
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
