walking98 commented on a change in pull request #3: Polish the code as spring's best practice URL: https://github.com/apache/rocketmq-spring/pull/3#discussion_r241679338
########## File path: rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/config/ListenerContainerConfiguration.java ########## @@ -42,6 +42,7 @@ import java.util.concurrent.atomic.AtomicLong; +@Configuration Review comment: Is this annotation optional ? since it is imported (@Import) by root configuration class: RocketMQAutoConfiguration.java @snicoll ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
