walking98 commented on a change in pull request #4: 修复当ObjectMapper 的 Bean
已存在时候，不叫rocketMQMessageObjectMapper，无法启动
URL: https://github.com/apache/rocketmq-spring/pull/4#discussion_r241680550
##########
File path:
rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/config/RocketMQAutoConfiguration.java
##########
@@ -66,7 +66,7 @@ public DefaultMQProducer
defaultMQProducer(RocketMQProperties rocketMQProperties
@Bean
@ConditionalOnClass(name = "com.fasterxml.jackson.databind.ObjectMapper")
- @ConditionalOnMissingBean(ObjectMapper.class)
+ @ConditionalOnMissingBean(name = "rocketMQMessageObjectMapper")
Review comment:
Thanks for the quick reply @snicoll . The issue is "if there is another bean
ObjectMapper existing in the context, the starter can not startup"
I guess the bean is injected by other AutoConfig/Config...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
