vongosling commented on a change in pull request #4: Can't start when there is 
a ObjectMapper bean name exist instead of naming rocketMQMessageObjectMapper
URL: https://github.com/apache/rocketmq-spring/pull/4#discussion_r241690812
 
 

 ##########
 File path: 
rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/config/RocketMQAutoConfiguration.java
 ##########
 @@ -66,7 +66,7 @@ public DefaultMQProducer 
defaultMQProducer(RocketMQProperties rocketMQProperties
 
     @Bean
     @ConditionalOnClass(name = "com.fasterxml.jackson.databind.ObjectMapper")
-    @ConditionalOnMissingBean(ObjectMapper.class)
+    @ConditionalOnMissingBean(name = "rocketMQMessageObjectMapper")
 
 Review comment:
   > I don't know if you're asking me. The issue has non english description so 
I didn't get it.
   
   @snicoll  I have change the title to english :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to