wenfengwang commented on a change in pull request #12: More Configurable fields
and mores
URL: https://github.com/apache/rocketmq-client-go/pull/12#discussion_r241986114
##########
File path: core/api.go
##########
@@ -23,20 +23,31 @@ func Version() (version string) {
}
// NewProduer create a new producer with config
-func NewProduer(config *ProducerConfig) Producer {
+func NewProduer(config *ProducerConfig) (Producer, error) {
return newDefaultProducer(config)
}
// ProducerConfig define a producer
type ProducerConfig struct {
- GroupID string
- NameServer string
- Credentials *SessionCredentials
+ GroupID string
+ NameServer string
+ NameServerDomain string
+ GroupName string
+ InstanceName string
+ Credentials *SessionCredentials
+
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
