vongosling closed pull request #11: Enhance consumer classes so that consumer
classes can be inherited
URL: https://github.com/apache/rocketmq-spring/pull/11
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/support/DefaultRocketMQListenerContainer.java
b/rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/support/DefaultRocketMQListenerContainer.java
index 1993035..ce1b388 100644
---
a/rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/support/DefaultRocketMQListenerContainer.java
+++
b/rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/support/DefaultRocketMQListenerContainer.java
@@ -348,7 +348,13 @@ private Object doConvertMessage(MessageExt messageExt) {
}
private Class getMessageType() {
- Type[] interfaces =
AopUtils.getTargetClass(rocketMQListener).getGenericInterfaces();
+ Class<?> targetClass = AopUtils.getTargetClass(rocketMQListener);
+ Type[] interfaces = targetClass.getGenericInterfaces();
+ Class<?> superclass = targetClass.getSuperclass();
+ while ((Objects.isNull(interfaces) || 0 == interfaces.length) &&
Objects.nonNull(superclass)) {
+ interfaces = superclass.getGenericInterfaces();
+ superclass = targetClass.getSuperclass();
+ }
if (Objects.nonNull(interfaces)) {
for (Type type : interfaces) {
if (type instanceof ParameterizedType) {
diff --git
a/rocketmq-spring-boot/src/test/java/org/apache/rocketmq/spring/support/DefaultRocketMQListenerContainerTest.java
b/rocketmq-spring-boot/src/test/java/org/apache/rocketmq/spring/support/DefaultRocketMQListenerContainerTest.java
new file mode 100644
index 0000000..5787689
--- /dev/null
+++
b/rocketmq-spring-boot/src/test/java/org/apache/rocketmq/spring/support/DefaultRocketMQListenerContainerTest.java
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.spring.support;
+import org.apache.rocketmq.common.message.MessageExt;
+import org.apache.rocketmq.spring.core.RocketMQListener;
+import org.junit.Test;
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import static org.assertj.core.api.Assertions.assertThat;
+public class DefaultRocketMQListenerContainerTest {
+ @Test
+ public void testGetMessageType() throws NoSuchMethodException {
+ DefaultRocketMQListenerContainer listenerContainer = new
DefaultRocketMQListenerContainer();
+ Method getMessageType =
DefaultRocketMQListenerContainer.class.getDeclaredMethod("getMessageType");
+ getMessageType.setAccessible(true);
+ try {
+ listenerContainer.setRocketMQListener(new BaseStringConsumer());
+ Class result = (Class) getMessageType.invoke(listenerContainer);
+
assertThat(result.getName().equals(String.class.getName())).isTrue();
+ listenerContainer.setRocketMQListener(new
BaseMessageExtConsumer());
+ result = (Class) getMessageType.invoke(listenerContainer);
+
assertThat(result.getName().equals(MessageExt.class.getName())).isTrue();
+ listenerContainer.setRocketMQListener(new
ConcreteStringConsumer());
+ result = (Class) getMessageType.invoke(listenerContainer);
+
assertThat(result.getName().equals(String.class.getName())).isTrue();
+ listenerContainer.setRocketMQListener(new
ConcreteMessageExtConsumer());
+ result = (Class) getMessageType.invoke(listenerContainer);
+
assertThat(result.getName().equals(MessageExt.class.getName())).isTrue();
+ } catch (IllegalAccessException | InvocationTargetException e) {
+ e.printStackTrace();
+ }
+ }
+}
+class BaseStringConsumer implements RocketMQListener<String> {
+ @Override
+ public void onMessage(String message) {
+ }
+}
+class ConcreteStringConsumer extends BaseStringConsumer {
+}
+class BaseMessageExtConsumer implements RocketMQListener<MessageExt> {
+ @Override
+ public void onMessage(MessageExt message) {
+ }
+}
+class ConcreteMessageExtConsumer extends BaseMessageExtConsumer {
+}
\ No newline at end of file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
