ifplusor commented on a change in pull request #20: Fixed deadlock, and add args field for python callback. URL: https://github.com/apache/rocketmq-client-python/pull/20#discussion_r244256005
########## File path: src/PythonWrapper.cpp ########## @@ -22,6 +22,7 @@ #include "CPushConsumer.h" #include "PythonWrapper.h" #include <boost/python.hpp> +#include <boost/thread.hpp> Review comment: In my case, i link libboost_thread.so in librocketmq.so, it is ok. But the official project of rocketmq-client-cpp link libboost_*.a, i don't test. libboost_python is independent, but libboost_thread depend libboost_system. and boost::this_thread::disable_interruption is necessary in PythonMessageCallBackInner, i will remove it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
