stcai commented on a change in pull request #66: Resolve the compile warning
and bug
URL: https://github.com/apache/rocketmq-client-cpp/pull/66#discussion_r247577211
##########
File path: src/consumer/PullRequest.cpp
##########
@@ -262,7 +262,7 @@ bool PullRequest::addPullMsgEvent() {
return false;
}
-int PullRequest::getLatestPullRequestOpaque() const {
+int PullRequest::getLatestPullRequestOpaque() {
boost::lock_guard<boost::mutex> lock(m_pullRequestLock);
Review comment:
Maybe turn ‘m_bPullMsgEventInprogress’ to a mutable member is a better
choice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
