ymwneu commented on issue #664: RemotingUtil has a logic bug URL: https://github.com/apache/rocketmq/issues/664#issuecomment-456290447 Notice the line 175. When configureBlocking is true, the connect() will blocking until the connection established or timeout. But if configureBlocking is false, we should use socketChannel#finishConnect() to check whether the connection is established, it will bring additional work. So, i think in line 170, it make sure the socketChannel is blocking before connect() is invoked.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
