lizhanhui commented on a change in pull request #60: Update: update network
interface.
URL: https://github.com/apache/rocketmq-client-cpp/pull/60#discussion_r257546561
##########
File path: src/common/AsyncCallbackWrap.h
##########
@@ -38,29 +39,27 @@ enum asyncCallBackType {
struct AsyncCallbackWrap {
public:
- AsyncCallbackWrap(AsyncCallback* pAsyncCallback, MQClientAPIImpl*
pclientAPI);
+ AsyncCallbackWrap(AsyncCallback *pAsyncCallback, MQClientAPIImpl
*pClientAPI);
virtual ~AsyncCallbackWrap();
- virtual void operationComplete(ResponseFuture* pResponseFuture,
- bool bProducePullRequest) = 0;
+ virtual void onComplete(ResponseFuture *pResponseFuture) = 0;
virtual void onException() = 0;
virtual asyncCallBackType getCallbackType() = 0;
protected:
- AsyncCallback* m_pAsyncCallBack;
- MQClientAPIImpl* m_pClientAPI;
+ AsyncCallback *m_pAsyncCallBack;
+ MQClientAPIImpl *m_pClientAPI;
};
//<!************************************************************************
class SendCallbackWrap : public AsyncCallbackWrap {
public:
- SendCallbackWrap(const string& brokerName, const MQMessage& msg,
- AsyncCallback* pAsyncCallback, MQClientAPIImpl* pclientAPI);
+ SendCallbackWrap(const string &brokerName, const MQMessage &msg,
Review comment:
Nice catch, best to avoid namespace pollution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
