boypt commented on issue #1134: FIX: HmacSHA1 not found if JAVA_HOME set to JRE
URL: https://github.com/apache/rocketmq/pull/1134#issuecomment-480497087
 
 
   > > > > @boypt Hi your pr shoud be committed to develop branch rather than 
master branch.Thanks.
   > > > 
   > > > 
   > > > OK. I change the branch.
   > > 
   > > 
   > > And
   > > > > @boypt Hi your pr shoud be committed to develop branch rather than 
master branch.Thanks.
   > > > 
   > > > 
   > > > OK. I change the branch.
   > > 
   > > 
   > > Okay,and please look at your commits which includes in your PR.Please 
rebase your code in your local enviroment firstly. @boypt
   
   sorry I messed that up. I push another PR as #1140 , please review

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to