zongtanghu commented on a change in pull request #1149: [issue#1147]Broker will
report Exception if open the aclEnable and enableDLegerCommitLog flag at the
same time.
URL: https://github.com/apache/rocketmq/pull/1149#discussion_r274756074
##########
File path:
acl/src/main/java/org/apache/rocketmq/acl/plain/PlainAccessValidator.java
##########
@@ -53,15 +53,17 @@ public AccessResource parse(RemotingCommand request,
String remoteAddr) {
accessResource.setWhiteRemoteAddress(remoteAddr);
}
+ accessResource.setRequestCode(request.getCode());
+
if (request.getExtFields() == null) {
- throw new AclException("request's extFields value is null");
+ //If request's extFields is null,then return accessResource
directly(users can use whiteAddress pattern)
+ return accessResource;
}
Review comment:
Hi, @dongeforever I return back my pr's codes to original ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
