zongtanghu commented on a change in pull request #1210: [ISSUE #1199] Implement
the 1.0.0 openmessaging consumer API for rocketmq oms module
URL: https://github.com/apache/rocketmq/pull/1210#discussion_r285363120
##########
File path:
openmessaging/src/main/java/io/openmessaging/rocketmq/MessagingAccessPointImpl.java
##########
@@ -54,15 +57,76 @@ public Producer createProducer() {
}
@Override public Consumer createConsumer() {
- return null;
+ String consumerId = accessPointProperties.getString("CONSUMER_ID");
Review comment:
Here,do you want to distinguish pullConsumer from pushConsumer by the
"CONSUMER_ID" key related value?And do you want set what's string value by
using messagingAccessPoint.createPullConsumer method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
