odbozhou commented on a change in pull request #1210: [ISSUE #1199] Implement
the 1.0.0 openmessaging consumer API for rocketmq oms module
URL: https://github.com/apache/rocketmq/pull/1210#discussion_r285385970
##########
File path:
openmessaging/src/main/java/io/openmessaging/rocketmq/MessagingAccessPointImpl.java
##########
@@ -54,15 +57,76 @@ public Producer createProducer() {
}
@Override public Consumer createConsumer() {
- return null;
+ String consumerId = accessPointProperties.getString("CONSUMER_ID");
+ String[] nsStrArr = consumerId.split("_");
+ if (nsStrArr.length < 2) {
+ return new PushConsumerImpl(accessPointProperties);
+ }
+ if ("pull".equals(nsStrArr[0])) {
Review comment:
It has been modified
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
