vongosling commented on a change in pull request #1217: [ISSUE #1156]new 
mqadmin API for ACL configuration
URL: https://github.com/apache/rocketmq/pull/1217#discussion_r293364450
 
 

 ##########
 File path: acl/src/main/java/org/apache/rocketmq/acl/AccessValidator.java
 ##########
 @@ -35,4 +37,32 @@
      * @param accessResource
      */
     void validate(AccessResource accessResource);
+
+    /**
+     * update the access resource config
 
 Review comment:
   The first letter needs to be capitalized. The first letter needs to be 
capitalized. The first letter needs to be capitalized. Three times make help to 
remember.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to