ShannonDing commented on a change in pull request #1257: [ISSUE #1156]Add new
mqadmin API for ACL configuration
URL: https://github.com/apache/rocketmq/pull/1257#discussion_r294031344
##########
File path: acl/src/main/java/org/apache/rocketmq/acl/common/AclUtils.java
##########
@@ -146,13 +148,31 @@ public static boolean isMinus(String minus) {
}
}
+ public static boolean writeDataObject(String path, Map<String,Object>
dataMap) {
+ Yaml yaml = new Yaml();
+ PrintWriter pw = null;
+ try {
+ pw = new PrintWriter(new FileWriter(path));
Review comment:
Should this "new FileWriter(path)" handler be closed after use?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
