jonnxu commented on a change in pull request #157: remove
removeDropedPullRequestOpaque and deleteOpaqueForDropPullRequest.
URL:
https://github.com/apache/rocketmq-client-cpp/pull/157#discussion_r294049101
##########
File path: src/MQClientAPIImpl.cpp
##########
@@ -467,21 +463,7 @@ void MQClientAPIImpl::pullMessageAsync(const string& addr,
void* pArg) {
//<!delete in future;
AsyncCallbackWrap* cbw = new PullCallbackWarp(pullCallback, this, pArg);
- MQMessageQueue mq;
- AsyncArg* pAsyncArg = static_cast<AsyncArg*>(pArg);
- if (pAsyncArg && pAsyncArg->pPullRequest) {
- mq = pAsyncArg->mq;
- pAsyncArg->pPullRequest->setLatestPullRequestOpaque(request.getOpaque());
- LOG_DEBUG("pullMessageAsync set opaque:%d, mq:%s",
pAsyncArg->pPullRequest->getLatestPullRequestOpaque(),
- mq.toString().c_str());
- }
-
if (m_pRemotingClient->invokeAsync(addr, request, cbw, timeoutMillis) ==
false) {
- LOG_ERROR("pullMessageAsync failed of addr:%s, opaque:%d, mq:%s",
addr.c_str(), request.getOpaque(),
Review comment:
i suggest reserve this log
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
