ifplusor commented on a change in pull request #156: [ISSUE #137] split 
TcpRemotingClient::m_ioService into m_dispatchService and m_handleService
URL: 
https://github.com/apache/rocketmq-client-cpp/pull/156#discussion_r294052604
 
 

 ##########
 File path: src/transport/TcpRemotingClient.cpp
 ##########
 @@ -482,7 +498,7 @@ void TcpRemotingClient::ProcessData(const MemoryBlock& 
mem, const string& addr)
     LOG_DEBUG("find_response opaque:%d", opaque);
     processResponseCommand(pRespondCmd, pFuture);
   } else {
-    processRequestCommand(pRespondCmd, addr);
 
 Review comment:
   No. Do it will write another function for call processRequest and 
invokeOneway, it is unnecessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to