ChaosYjh commented on a change in pull request #1275: [ISSSUE 1188]Fix the
problem when more than one producer or consumer in the same process can trace
only one
URL: https://github.com/apache/rocketmq/pull/1275#discussion_r295585195
##########
File path:
client/src/main/java/org/apache/rocketmq/client/trace/AsyncTraceDispatcher.java
##########
@@ -159,6 +161,10 @@ private DefaultMQProducer
getAndCreateTraceProducer(RPCHook rpcHook) {
return traceProducerInstance;
}
+ private String genGroupNameForTrace() {
+ return TraceConstants.GROUP_NAME_PREFIX + "-" + this.group;
Review comment:
> if it can trace when the multi consumers or producers with the same group
name?
Only the first traceProducer can trace, and the other will be start failed.
If specify a instanceName for each group, it will create multi client instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
