wenfengwang commented on a change in pull request #85: [ISSUE #86] Add Interceptor for producer and consumer. URL: https://github.com/apache/rocketmq-client-go/pull/85#discussion_r300817344
########## File path: primitive/interceptor.go ########## @@ -0,0 +1,57 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package primitive + +import ( + "context" +) + +// PInvoker finish a send invoke on producer. +type PInvoker func(ctx context.Context, req, reply interface{}) error + +// PInterceptor intercepts the execution of a send invoke on producer. +type PInterceptor func(ctx context.Context, req, reply interface{}, next PInvoker) error Review comment: The PInterceptor and CInterceptor have the same function signature, why not use one definition as below: ``` type Invoker func(ctx context.Context, req, reply interface{}) error type Interceptor func(ctx context.Context, req, reply interface{}, next Invoker) error ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
