wenfengwang commented on a change in pull request #97: fix remote timeout unit
and add shutdown method
URL: https://github.com/apache/rocketmq-client-go/pull/97#discussion_r300972084
##########
File path: internal/kernel/client.go
##########
@@ -95,6 +95,7 @@ type RMQClient struct {
remoteClient *remote.RemotingClient
hbMutex sync.Mutex
+ cancel context.CancelFunc
Review comment:
IMO, could we add a field like `state` that is updated to `shutdown` when
`Shutdown()` called instead of `cancel`, and return error like
`errors.New("client closed")` when `Send*()` called
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
