wenfengwang commented on a change in pull request #103: [ISSUE #93] More
usability API
URL: https://github.com/apache/rocketmq-client-go/pull/103#discussion_r301387316
##########
File path: api.go
##########
@@ -19,37 +19,41 @@ package rocketmq
import (
"context"
-
+ "github.com/apache/rocketmq-client-go/consumer"
"github.com/apache/rocketmq-client-go/primitive"
+ "github.com/apache/rocketmq-client-go/producer"
)
type Producer interface {
Start() error
Shutdown() error
- SendSync(context.Context, ...*primitive.Message) (primitive.SendResult,
error)
- SendAsync(context.Context, func(primitive.SendResult),
...*primitive.Message) error
- SendOneWay(context.Context, ...*primitive.Message) error
+ SendSync(context.Context, *primitive.Message) (*primitive.SendResult,
error)
+ SendAsync(context.Context, func(context.Context,
*primitive.SendResult), *primitive.Message) error
+ SendOneWay(context.Context, *primitive.Message) error
}
-func NewProducer(opt primitive.ProducerOptions) (Producer, error) {
- return nil, nil
+func NewProducer(opts ...producer.Option) (Producer, error) {
+ return producer.NewDefaultProducer(opts...)
}
type PushConsumer interface {
Start() error
Shutdown() error
- Subscribe(topic string, selector primitive.MessageSelector,
- f func(context.Context, ...*primitive.MessageExt)
(primitive.ConsumeResult, error)) error
+ Subscribe(topic string, selector consumer.MessageSelector,
+ f func(context.Context, ...*primitive.MessageExt)
(consumer.ConsumeResult, error)) error
Unsubscribe(string) error
}
+func NewPushConsumer(opts ...consumer.Option) (PushConsumer, error) {
+ return consumer.NewPushConsumer(opts...)
+}
+
type PullConsumer interface {
Start() error
Shutdown() error
- Pull(context.Context, string, primitive.MessageSelector, int)
(primitive.PullResult, error)
- PullFrom(context.Context, primitive.MessageQueue, int64, int)
(primitive.PullResult, error)
+ Pull(context.Context, string, consumer.MessageSelector, int)
(*primitive.PullResult, error)
+ PullFrom(context.Context, primitive.MessageQueue, int64, int)
(*primitive.PullResult, error)
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
