wenfengwang commented on a change in pull request #107: [ISSUE #75] Change
fatal to error in
URL: https://github.com/apache/rocketmq-client-go/pull/107#discussion_r301864961
##########
File path: consumer/push_consumer.go
##########
@@ -230,70 +230,70 @@ func (pc *pushConsumer) validate() {
if pc.consumerGroup == internal.DefaultConsumerGroup {
// TODO FQA
- rlog.Fatalf("consumerGroup can't equal [%s], please specify
another one.", internal.DefaultConsumerGroup)
+ rlog.Errorf("consumerGroup can't equal [%s], please specify
another one.", internal.DefaultConsumerGroup)
Review comment:
return an `error`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
