vongosling commented on a change in pull request #635: [ISSUE-1316]Enhance
share netty handler
URL: https://github.com/apache/rocketmq/pull/635#discussion_r302508227
##########
File path:
remoting/src/test/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstractTest.java
##########
@@ -90,4 +93,18 @@ public void operationComplete(final ResponseFuture
responseFuture) {
semaphore.acquire(1);
assertThat(semaphore.availablePermits()).isEqualTo(0);
}
+
+ @Test
Review comment:
It would be better add share handler test in here, not judge null case but
also the same object judgment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
