[GitHub] [rocketmq] ahuazhu commented on issue #1355: Each ConsumeMessageThread should have different thread name

[GitBox]

ahuazhu commented on issue #1355: Each ConsumeMessageThread should have 
different thread name
URL: https://github.com/apache/rocketmq/issues/1355#issuecomment-517106015
 
 
   What about if modifying the code in `ConsumeMessageConcurrentlyService.java` 
   from
   ```
               this.consumeExecutor = new ThreadPoolExecutor(
               this.defaultMQPushConsumer.getConsumeThreadMin(),
               this.defaultMQPushConsumer.getConsumeThreadMax(),
               1000 * 60,
               TimeUnit.MILLISECONDS,
               this.consumeRequestQueue,
               new ThreadFactoryImpl("ConsumeMessageThread_"));
   
           this.scheduledExecutorService = 
Executors.newSingleThreadScheduledExecutor(new 
ThreadFactoryImpl("ConsumeMessageScheduledThread_"));
           this.cleanExpireMsgExecutors = 
Executors.newSingleThreadScheduledExecutor(new 
ThreadFactoryImpl("CleanExpireMsgScheduledThread_"));
   ```
   
   to
   
   ```
               this.consumeExecutor = new ThreadPoolExecutor(
               this.defaultMQPushConsumer.getConsumeThreadMin(),
               this.defaultMQPushConsumer.getConsumeThreadMax(),
               1000 * 60,
               TimeUnit.MILLISECONDS,
               this.consumeRequestQueue,
               new ThreadFactoryImpl("ConsumeMessageThread_" + 
this.consumerGroup + "_"));
   
           this.scheduledExecutorService = 
Executors.newSingleThreadScheduledExecutor(new 
ThreadFactoryImpl("ConsumeMessageScheduledThread_" + this.consumerGroup + "_"));
           this.cleanExpireMsgExecutors = 
Executors.newSingleThreadScheduledExecutor(new 
ThreadFactoryImpl("CleanExpireMsgScheduledThread_" + this.consumerGroup + "_"));
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services