xiangwangcheng commented on a change in pull request #1354: Update
BrokerOuterAPI.java
URL: https://github.com/apache/rocketmq/pull/1354#discussion_r310428182
##########
File path:
broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java
##########
@@ -123,7 +124,7 @@ public void updateNameServerAddressList(final String
addrs) {
final int timeoutMills,
final boolean compressed) {
- final List<RegisterBrokerResult> registerBrokerResultList =
Lists.newArrayList();
+ final List<RegisterBrokerResult> registerBrokerResultList =
Collections.synchronizedList(Lists.newArrayList());
Review comment:
I don't understand why we need a synchronized List here? Can u write a test
case or sth to prove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
