duhenglucky commented on a change in pull request #348: merge rmq client and
bugfix rmq sourceTask setNamesrv error
URL: https://github.com/apache/rocketmq-externals/pull/348#discussion_r310657595
##########
File path:
rocketmq-connect/rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/utils/datasync/BrokerBasedLog.java
##########
@@ -90,27 +90,24 @@ public BrokerBasedLog(ConnectConfig connectConfig,
this.topicName = topicName;
this.dataSynchronizerCallback = dataSynchronizerCallback;
- producer = new DefaultMQProducer();
+ this.producer = new DefaultMQProducer();
this.producer.setNamesrvAddr(connectConfig.getNamesrvAddr());
+
this.producer.setInstanceName(ConnectUtil.createInstance(connectConfig.getNamesrvAddr()));
this.producer.setProducerGroup(consumerId);
Review comment:
It is recommended to use producerId/producerGroup config instead of
consumerId.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
