vongosling commented on a change in pull request #1: Add licenses and notice for 3rd-party dependencies URL: https://github.com/apache/rocketmq-ons-cpp/pull/1#discussion_r310950515
########## File path: licenses/NOTICE-BIN ########## @@ -0,0 +1,32 @@ +Apache RocketMQ +Copyright 2016-2019 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +------ +This product has a bundle netty: + The Netty Project + ================= + +Please visit the Netty web site for more information: + + * http://netty.io/ + +Copyright 2014 The Netty Project + +The Netty Project licenses this file to you under the Apache License, +version 2.0 (the "License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at: + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +License for the specific language governing permissions and limitations +under the License. + Review comment: @justinmclean Can you help me to check the accuracy of the notice file? I'm not sure about what exactly can we put in a notice file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
