wenfengwang commented on a change in pull request #181: [ISSUE #180]add tag 
filter example.
URL: https://github.com/apache/rocketmq-client-go/pull/181#discussion_r317444496
 
 

 ##########
 File path: consumer/push_consumer.go
 ##########
 @@ -493,6 +493,8 @@ func (pc *pushConsumer) pullMessage(request *PullRequest) {
                        goto NEXT
                }
 
+               pc.processPullResult(request.mq, result, sd)
 
 Review comment:
   the L507 will overwrite result of `pc.processPullResult(request.mq, result, 
sd)`, could you delete L507 and retest? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to