ShannonDing commented on a change in pull request #181: [ISSUE #180]add tag
filter example.
URL: https://github.com/apache/rocketmq-client-go/pull/181#discussion_r319336000
##########
File path: consumer/consumer.go
##########
@@ -799,10 +799,10 @@ func (dc *defaultConsumer) processPullResult(mq
*primitive.MessageQueue, result
// filter message according to tags
msgListFilterAgain := msgs
- if len(data.Tags) > 0 && data.ClassFilterMode {
+ if data.Tags.Len() > 0 && data.ClassFilterMode {
Review comment:
Why make msgListFilterAgain with a length of len(msgs).
Maybe it should be initialized to zero.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
