ShannonDing commented on a change in pull request #12: [ISSUE #13]Add
OpenMessaging API support
URL: https://github.com/apache/rocketmq-ons/pull/12#discussion_r321138435
##########
File path:
ons-core/ons-client/src/main/java/org/apache/rocketmq/ons/api/impl/rocketmq/ONSClientAbstract.java
##########
@@ -74,16 +75,16 @@ public ONSClientAbstract(Properties properties) {
this.sessionCredentials.updateContent(properties);
if (this.sessionCredentials.getOnsChannel().equals(ONSChannel.ALIYUN)
&&
(null == this.sessionCredentials.getAccessKey() ||
"".equals(this.sessionCredentials.getAccessKey()))) {
- throw new ONSClientException("please set access key");
+ throw new OMSRuntimeException("please set access key");
Review comment:
As the default onsChannel was changed to "ALIYUN", Exception will be thrown
if the access key or secret key is not set when connecting local broker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
