duhenglucky commented on a change in pull request #1403: [issue #1400]do disk
space detection in another thread
URL: https://github.com/apache/rocketmq/pull/1403#discussion_r322182442
##########
File path:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
##########
@@ -1261,6 +1264,11 @@ public void run() {
// DefaultMessageStore.this.cleanExpiredConsumerQueue();
// }
// }, 1, 1, TimeUnit.HOURS);
+ this.diskCheckScheduledExecutorService.scheduleAtFixedRate(new
Runnable() {
Review comment:
yes, due to the code coverage decreased by more than 1%, so it would be nice
if you can add some unit tests, especially for the isSpaceFull() method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
