messense commented on a change in pull request #72: style(client) polish code
style
URL:
https://github.com/apache/rocketmq-client-python/pull/72#discussion_r343993315
##########
File path: rocketmq/client.py
##########
@@ -208,41 +202,38 @@ def __init__(self, group_id, orderly=False,
timeout=None, compress_level=None, m
def __enter__(self):
self.start()
- def __exit__(self, type, value, traceback):
+ def __exit__(self, type1, value, traceback):
Review comment:
`object.__exit__(self, exc_type, exc_value, traceback)`
https://docs.python.org/3/reference/datamodel.html#object.__exit__
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
