liuruiyiyang commented on a change in pull request #10: fix stage replace
ROCKETMQ_VERSION error image name
URL: https://github.com/apache/rocketmq-docker/pull/10#discussion_r344144207
##########
File path: templates/docker-compose/docker-compose.yml
##########
@@ -44,4 +44,15 @@ services:
- ./data1/broker/logs:/home/rocketmq/logs
- ./data1/broker/store:/home/rocketmq/store
-
./data1/broker/conf/broker.conf:/opt/rocketmq-ROCKETMQ_VERSION/conf/broker.conf
- command: sh mqbroker -c ../conf/broker.conf
+ command: sh mqbroker -c /opt/rocketmq-ROCKETMQ_VERSION/conf/broker.conf
+
+ # add console
+ console:
+ image: styletang/rocketmq-console-ng:latest
Review comment:
Please use the community public docker repository ```apacherocketmq```
instead of ```styletang```, and please add the Dockerfile, related scripts in
the ```build``` package which produces the ```rocketmq-console-ng``` image.
Adding some documents is even better for other people understanding your work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
