Hi,
+1(binding), I have checked:
-Checksums and PGP signatures are valid for Source package.
-Checksums and PGP signatures are valid for Binary package.
-Source code artifacts have correct names matching the current release.
-Binary artifacts have correct names matching the current release.
-License and Notice are correct in source package.
-License and Notice are correct in binary package.
-All files have license headers in source package if necessary.
-No compiled archives bundled in source archive.
-Hash and Tag in GitHub repo is matching the current artifacts.
-The code can be built success in the source package.
@Justin, binary release are arranged as multi-platform support, there are
single LICENSE and NOTICE in every different platform, such as CentOS 6, CentOS
7.
> On Nov 15, 2019, at 5:41 AM, Justin Mclean <[email protected]> wrote:
>
> HI,
>
> +1 (binding) for the source release
>
> For the source release I checked:
> - signatures and hashes are fine
> - LICENSE and NOTICE all correct
> - All source files have ASF header where needed
> - No unexpected binary files
> - Can compile from source
>
> The binary release artefact is missing both LICENSE And NOTICE files at the
> top level.
>
> Thanks,
> Justin
