ShannonDing commented on a change in pull request #325: message add
GetProperties func
URL: https://github.com/apache/rocketmq-client-go/pull/325#discussion_r354158725
##########
File path: primitive/message.go
##########
@@ -133,6 +133,10 @@ func (m *Message) UnmarshalProperties(data []byte) {
}
}
+func (m *Message) GetProperties() map[string]string {
+ return m.properties
Review comment:
I think it would be better to use a deep copy here. Reference copy may cause
multi-threaded to read and write competition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services