xiangwangcheng commented on issue #1632: fix async invoke timeout is not 
accurate
URL: https://github.com/apache/rocketmq/pull/1632#issuecomment-564340227
 
 
   1. The `scanResponseTable()` method is invoked periodically(every one 
second), it could be late for one second for one particular reponseFuture to be 
scanned,  in the worst case.  So 
   `(rep.getBeginTimestamp() + rep.getTimeoutMillis() + 1000) <= 
System.currentTimeMillis()`
   does mean something.
   
   2. Could you please change the destination branch to devleop?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to