duhenglucky commented on a change in pull request #1625: [ISSUE #1639] use ipv4
first when choosing local IP
URL: https://github.com/apache/rocketmq/pull/1625#discussion_r362715260
##########
File path: common/src/main/java/org/apache/rocketmq/common/UtilAll.java
##########
@@ -547,8 +547,6 @@ public static String ipToIPv6Str(byte[] ip) {
if (ipV6Check(ipByte)) {
if (!isInternalV6IP(ip)) {
return ipByte;
- } else if (internalIP == null) {
Review comment:
yep, what I thought was that if no address was selected here, use fakeIp
instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
