areyouok opened a new issue #1694: Transaction check dropped if channel is busy URL: https://github.com/apache/rocketmq/issues/1694 On current develop branch, run org.apache.rocketmq.example.benchmark.TransactionProducer with parameters: ``` -n 127.0.0.1:9876 -s 128 -w 64 -sr 0.01 -su 0.05 -cu 0.2 ``` Unexpected transaction check may occurs: ``` 20:13:39.501 [main] DEBUG i.n.u.i.l.InternalLoggerFactory - Using SLF4J as the default logging framework RocketMQLog:WARN No appenders could be found for logger (io.netty.util.internal.PlatformDependent0). RocketMQLog:WARN Please initialize the logger system properly. Send TPS: 142 Max RT: 335 AVG RT:28.0 Send Failed: 0 check: 0 unexpectedCheck: 0 duplicatedCheck: 0 Send TPS: 130 Max RT: 104 AVG RT:30.6 Send Failed: 0 check: 0 unexpectedCheck: 0 duplicatedCheck: 0 Send TPS: 136 Max RT: 117 AVG RT:29.3 Send Failed: 0 check: 138 unexpectedCheck: 0 duplicatedCheck: 0 Send TPS: 90 Max RT: 99 AVG RT:44.2 Send Failed: 0 check: 0 unexpectedCheck: 0 duplicatedCheck: 0 Send TPS: 101 Max RT: 92 AVG RT:39.5 Send Failed: 0 check: 0 unexpectedCheck: 0 duplicatedCheck: 0 Send TPS: 90 Max RT: 61 AVG RT:44.3 Send Failed: 0 check: 0 unexpectedCheck: 0 duplicatedCheck: 0 Send TPS: 100 Max RT: 61 AVG RT:39.6 Send Failed: 0 check: 0 unexpectedCheck: 0 duplicatedCheck: 0 Send TPS: 103 Max RT: 126 AVG RT:38.3 Send Failed: 0 check: 0 unexpectedCheck: 0 duplicatedCheck: 0 Send TPS: 858 Max RT: 193 AVG RT:4.7 Send Failed: 0 check: 324 unexpectedCheck: 0 duplicatedCheck: 0 Send TPS: 156 Max RT: 66 AVG RT:25.5 Send Failed: 0 check: 0 unexpectedCheck: 0 duplicatedCheck: 0 Send TPS: 107 Max RT: 84 AVG RT:37.2 Send Failed: 0 check: 0 unexpectedCheck: 0 duplicatedCheck: 0 Send TPS: 117 Max RT: 80 AVG RT:34.2 Send Failed: 0 check: 0 unexpectedCheck: 0 duplicatedCheck: 0 Send TPS: 155 Max RT: 81 AVG RT:25.7 Send Failed: 0 check: 0 unexpectedCheck: 0 duplicatedCheck: 0 Send TPS: 137 Max RT: 79 AVG RT:29.2 Send Failed: 0 check: 0 unexpectedCheck: 0 duplicatedCheck: 0 20:16:08,062 unexpected check: msgId=AC126CB100002A9F000000005037F8B0,txId=AC126CB1000018B4AAC20EA437590C86,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:16:08,062 unexpected check: msgId=AC126CB100002A9F0000000050383B98,txId=AC126CB1000018B4AAC20EA437E90C96,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:16:08,062 unexpected check: msgId=AC126CB100002A9F000000005038C033,txId=AC126CB1000018B4AAC20EA4387F0CA3,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:16:08,063 unexpected check: msgId=AC126CB100002A9F00000000503924B3,txId=AC126CB1000018B4AAC20EA439130CB1,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE Send TPS: 163 Max RT: 75 AVG RT:24.5 Send Failed: 0 check: 738 unexpectedCheck: 4 duplicatedCheck: 0 Send TPS: 157 Max RT: 50 AVG RT:25.4 Send Failed: 0 check: 0 unexpectedCheck: 0 duplicatedCheck: 0 Send TPS: 152 Max RT: 86 AVG RT:26.3 Send Failed: 0 check: 0 unexpectedCheck: 0 duplicatedCheck: 0 Send TPS: 167 Max RT: 88 AVG RT:23.9 Send Failed: 0 check: 0 unexpectedCheck: 0 duplicatedCheck: 0 Send TPS: 161 Max RT: 51 AVG RT:24.6 Send Failed: 0 check: 0 unexpectedCheck: 0 duplicatedCheck: 0 Send TPS: 122 Max RT: 88 AVG RT:32.7 Send Failed: 0 check: 0 unexpectedCheck: 0 duplicatedCheck: 0 20:17:08,193 unexpected check: msgId=AC126CB100002A9F0000000059C0C69B,txId=AC126CB1000018B4AAC20EA52D6F36BC,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,194 unexpected check: msgId=AC126CB100002A9F0000000059C4F20A,txId=AC126CB1000018B4AAC20EA531B239E2,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,194 unexpected check: msgId=AC126CB100002A9F0000000059C5133D,txId=AC126CB1000018B4AAC20EA4FCE21FD7,checkTimes=3,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,218 unexpected check: msgId=AC126CB100002A9F0000000059C5346F,txId=AC126CB1000018B4AAC20EA507862135,checkTimes=3,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,219 unexpected check: msgId=AC126CB100002A9F0000000059C597F1,txId=AC126CB1000018B4AAC20EA50BEB2192,checkTimes=3,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,219 unexpected check: msgId=AC126CB100002A9F0000000059C9A727,txId=AC126CB1000018B4AAC20EA5334E3BF2,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,219 unexpected check: msgId=AC126CB100002A9F0000000059C9EA8D,txId=AC126CB1000018B4AAC20EA533783C10,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,219 unexpected check: msgId=AC126CB100002A9F0000000059CA0BC0,txId=AC126CB1000018B4AAC20EA5339F3C2E,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,219 unexpected check: msgId=AC126CB100002A9F0000000059CA2CF3,txId=AC126CB1000018B4AAC20EA533EA3C5B,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,220 unexpected check: msgId=AC126CB100002A9F0000000059CA4E26,txId=AC126CB1000018B4AAC20EA533ED3C5D,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,220 unexpected check: msgId=AC126CB100002A9F0000000059CC4395,txId=AC126CB1000018B4AAC20EA536923F0D,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,220 unexpected check: msgId=AC126CB100002A9F0000000059CCA832,txId=AC126CB1000018B4AAC20EA536923F0E,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,220 unexpected check: msgId=AC126CB100002A9F0000000059CCEA8C,txId=AC126CB1000018B4AAC20EA536C93F3B,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,220 unexpected check: msgId=AC126CB100002A9F0000000059CD0C4C,txId=AC126CB1000018B4AAC20EA53A0E414B,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,220 unexpected check: msgId=AC126CB100002A9F0000000059CD2D7F,txId=AC126CB1000018B4AAC20EA53A204158,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,220 unexpected check: msgId=AC126CB100002A9F0000000059CD7067,txId=AC126CB1000018B4AAC20EA53A29415E,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,220 unexpected check: msgId=AC126CB100002A9F0000000059CD919A,txId=AC126CB1000018B4AAC20EA53A54417B,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,221 unexpected check: msgId=AC126CB100002A9F0000000059CE5934,txId=AC126CB1000018B4AAC20EA53E4242E8,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,221 unexpected check: msgId=AC126CB100002A9F0000000059CE7A67,txId=AC126CB1000018B4AAC20EA53EB442F2,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,221 unexpected check: msgId=AC126CB100002A9F0000000059CE3801,txId=AC126CB1000018B4AAC20EA53D8542CD,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,221 unexpected check: msgId=AC126CB100002A9F0000000059CE9B9A,txId=AC126CB1000018B4AAC20EA540254327,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,221 unexpected check: msgId=AC126CB100002A9F0000000059CEBCCD,txId=AC126CB1000018B4AAC20EA5404B4329,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,221 unexpected check: msgId=AC126CB100002A9F0000000059CEDE00,txId=AC126CB1000018B4AAC20EA5404C432D,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,223 unexpected check: msgId=AC126CB100002A9F0000000059D55D01,txId=AC126CB1000018B4AAC20EA591AD4D65,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,223 unexpected check: msgId=AC126CB100002A9F0000000059D59F66,txId=AC126CB1000018B4AAC20EA592734D7A,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,224 unexpected check: msgId=AC126CB100002A9F0000000059D5C099,txId=AC126CB1000018B4AAC20EA592BF4D85,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,224 unexpected check: msgId=AC126CB100002A9F0000000059DD0C52,txId=AC126CB1000018B4AAC20EA5DC2C57E5,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,224 unexpected check: msgId=AC126CB100002A9F0000000059DD2E11,txId=AC126CB1000018B4AAC20EA5DD975809,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,224 unexpected check: msgId=AC126CB100002A9F0000000059DF6704,txId=AC126CB1000018B4AAC20EA5E6785917,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,224 unexpected check: msgId=AC126CB100002A9F0000000059DFCA9D,txId=AC126CB1000018B4AAC20EA5EA35598B,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,224 unexpected check: msgId=AC126CB100002A9F0000000059DFEBD0,txId=AC126CB1000018B4AAC20EA5EA7F5994,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,224 unexpected check: msgId=AC126CB100002A9F0000000059E02E36,txId=AC126CB1000018B4AAC20EA5EDAC59F8,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,225 unexpected check: msgId=AC126CB100002A9F0000000059E04F69,txId=AC126CB1000018B4AAC20EA5EDD95A0B,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE 20:17:08,225 unexpected check: msgId=AC126CB100002A9F0000000059E0709C,txId=AC126CB1000018B4AAC20EA5EE615A23,checkTimes=2,sendResult,lastCheckResult=COMMIT_MESSAGE Send TPS: 122 Max RT: 106 AVG RT:32.7 Send Failed: 0 check: 349 unexpectedCheck: 34 duplicatedCheck: 0 ``` This is because the channel is busy, so tx check drops. I create a PR to fix this: https://github.com/apache/rocketmq/pull/1627 This PR also fix some thread safe problem.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
