2259289435 commented on issue #1734: [ISSUE #1727] fix RequestCallback executed 
multi times
URL: https://github.com/apache/rocketmq/pull/1734#issuecomment-576996418
 
 
   > ## What is the purpose of the change
   > To fix problem mentioned in [ISSUE 
1727](https://github.com/apache/rocketmq/issues/1727)
   > When there is more than one DefaultMQProducerImpl instance in one process, 
RequestCallback is possible to be executed multi times.
   > 
   > ## Brief changelog
   > 1. move  `DefaultMQProducerImpl.timer` to `RequestFutureTable.timer` to 
avoid multi timer scan the future table;
   > 2. add flag to distinguish whether a ReqeustCallback has been executed or 
not;
   > 
   > ## Verifying this change
   > XXXX
   > 
   > Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   > 
   > * [x]  Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue.
   > * [x]  Format the pull request title like `[ISSUE #123] Fix 
UnknownException when host config not exist`. Each commit in the pull request 
should have a meaningful subject line and body.
   > * [x]  Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
   > * [x]  Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   > * [x]  Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   > * [ ]  If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   
   修改callback有点不好
   1,callback是很早之前就开放给客户端使用了,现在改为只能执行一次,对低版本升级兼容有影响
   
2,重复多次只有callback异常才会发生,我建议的是迭代的时候标记key,然后执行exception的时候再去removekey,这样也解决了并发问题,对原有的callback也没有影响。

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to