duhenglucky commented on a change in pull request #1775: min value for
autoCommitIntervalMillis. #1774
URL: https://github.com/apache/rocketmq/pull/1775#discussion_r379300367
##########
File path:
client/src/main/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumer.java
##########
@@ -315,7 +315,9 @@ public long getAutoCommitIntervalMillis() {
}
public void setAutoCommitIntervalMillis(long autoCommitIntervalMillis) {
- this.autoCommitIntervalMillis = autoCommitIntervalMillis;
+ if (autoCommitIntervalMillis >= 1000) {
Review comment:
It would be better if you can replace this magic number(1000) with a
constant variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
