+1



[OK]  Checksums and PGP signatures are valid for Source package.

[OK]  Source code artifacts have correct names matching the current release.

[OK]  License and Notice are correct in source package.

[OK]  No compiled archives bundled in source archive.

[OK]  Hash and Tag in GitHub repo is matching the current artifacts.

[OK] The code can be built success in the source package.





On 02/18/2020 13:29,Gosling Von<[email protected]> wrote:
Hi,

I don't know if it is the reason for the default email client on my Mac. There 
is something wrong with the format of the email. There is a large distance 
between the paragraph. We could remove style script and double-check before 
call for vote next time :-)

+1

I checked:
- signatures and hashes fine
- LICENSE and NOTICE looks ok
- All necessary files have license headers, in addition to the following file 
list[1]. Look forward to fixing it next time.
- No compiled archives bundled in source archive
- Release note seems clear for me


[1]

rocketmq-spring-all-2.1.0/rocketmq-spring-boot-samples/rocketmq-produce-demo/src/main/resources/application.properties
rocketmq-spring-all-2.1.0/rocketmq-spring-boot-samples/rocketmq-consume-demo/src/main/resources/application.properties
rocketmq-spring-all-2.1.0/rocketmq-spring-boot-samples/rocketmq-produce-acl-demo/src/main/resources/application.properties
rocketmq-spring-all-2.1.0/rocketmq-spring-boot-samples/rocketmq-consume-acl-demo/src/main/resources/application.properties

Best Regards,
Von Gosling


On Feb 13, 2020, at 2:00 PM, Rongtong Jin <[email protected]> 
wrote:

Hello RocketMQ Community,







This is the vote for the 2.1.0 release of Apache rocketmq-spring







The artifacts:




https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-spring/2.1.0-rc1/







The staging repo:




https://repository.apache.org/content/repositories/orgapacherocketmq-1040










Git tag for the release:




https://github.com/apache/rocketmq-spring/releases/tag/rocketmq-spring-all-2.1.0










Hash for the release tag:




6c8fc6ef596f114dfbaf6bddddbcc077eefb73b7










Release Notes:




http://rocketmq.apache.org/release_notes/release-notes-rocketmq-spring-2.1.0/










The artifacts have been signed with Key :




D606079AF789227A1F39928A02C8C9527DDD1959, which can be found in the keys




file:




https://dist.apache.org/repos/dist/dev/rocketmq/KEYS







Checklist for reference,

Note that this is not official policy but may help with checking releases.

Fill in the following:

[ ]  Checksums and PGP signatures are valid for Source package.

[ ]  Source code artifacts have correct names matching the current release.

[ ]  License and Notice are correct in source package.

[ ]  All files have license headers in source package if necessary.

[ ]  No compiled archives bundled in source archive.

[ ]  Hash and Tag in GitHub repo is matching the current artifacts.

[ ]  The code can be built success in the source package.

And any other check point is welcomed and please feel free to reply to this 
email, we sincerely hope to your feedback.













The vote will be open for at least 72 hours or until a necessary number of 
votes are reached.













Please vote accordingly:













[ ] +1 approve




[ ] +0 no opinion




[ ] -1 disapprove with the reason













Thanks,




The Apache RocketMQ Team

Reply via email to