[GitHub] [rocketmq] xujianhai666 opened a new issue #1796: [Broker] useless code

Thu, 27 Feb 2020 01:24:17 -0800 

xujianhai666 opened a new issue #1796: [Broker] useless code
URL: https://github.com/apache/rocketmq/issues/1796
 
 
   **FEATURE REQUEST**
   
   1. Please describe the feature you are requesting.
   AdminBrokerProcessor#getConsumeStats 里面
   
   
![image](https://user-images.githubusercontent.com/52450794/75428888-d6598400-5983-11ea-981c-581a0084eb28.png)
   
   这里，如果 group 已经没有连接了，868行就是 null 了，但是 这个时候 872 行 结果肯定是 0 > 0 
的判断，这个逻辑很拗口。感觉应该把 872 行的判断去掉
   
![image](https://user-images.githubusercontent.com/52450794/75429959-95fb0580-5985-11ea-95d7-59201c1f680a.png)
   
   
![image](https://user-images.githubusercontent.com/52450794/75430061-bc20a580-5985-11ea-924b-3ebdaad27ca9.png)
   
   
   2. Provide any additional detail on your proposed use case for this feature.
   
   2. Indicate the importance of this issue to you (blocker, must-have, 
should-have, nice-to-have). Are you currently using any workarounds to address 
this issue?
   
   4. If there are some sub-tasks using -[] for each subtask and create a 
corresponding issue to map to the sub task:
   
   - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 
description here, 
   - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 
description here,
   - ...
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to