duhenglucky commented on a change in pull request #1799: [ISSUE
#1798]feat(admin): remove group of deleted sub info when queryTopicConsumeB…
URL: https://github.com/apache/rocketmq/pull/1799#discussion_r385494020
##########
File path:
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
##########
@@ -1025,8 +1026,15 @@ private RemotingCommand
queryTopicConsumeByWho(ChannelHandlerContext ctx,
groups.addAll(groupInOffset);
}
+ HashSet<String> filteredGroups = new HashSet<String>();
Review comment:
@ IMHO, it seems that add a flag in the client will be a better choice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
