xujianhai666 commented on a change in pull request #1703: [ISSUE #1588] Fix
Issue 1588 retry doesn't work when sending msg in async mode and the broker is
down
URL: https://github.com/apache/rocketmq/pull/1703#discussion_r386025043
##########
File path:
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
##########
@@ -559,7 +559,7 @@ private SendResult sendDefaultImpl(
MessageQueue mq = null;
Exception exception = null;
SendResult sendResult = null;
- int timesTotal = communicationMode == CommunicationMode.SYNC ? 1 +
this.defaultMQProducer.getRetryTimesWhenSendFailed() : 1;
Review comment:
@duhenglucky So this pr has no effect, maybe we should close pr?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
