rushsky518 commented on a change in pull request #1814: Filter message key on
server side when query message
URL: https://github.com/apache/rocketmq/pull/1814#discussion_r386860151
##########
File path:
client/src/main/java/org/apache/rocketmq/client/impl/MQAdminImpl.java
##########
@@ -381,42 +380,12 @@ public void operationComplete(ResponseFuture
responseFuture) {
for (MessageExt msgExt : qr.getMessageList()) {
if (isUniqKey) {
if (msgExt.getMsgId().equals(key)) {
-
- if (messageList.size() > 0) {
Review comment:
i don't understand this logic is for what.
In unexpected situation, producer send msgs to broker(s) with the same
uniqKey, when query msg with the key, users may want to see all the msgs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
