[GitHub] [rocketmq-client-cpp] ShannonDing commented on a change in pull request #273: Use OpenSSL to add support for SSL communication with the server. Script add debug mode support.

[GitBox]

ShannonDing commented on a change in pull request #273: Use OpenSSL to add 
support for SSL communication with the server. Script add debug mode support.
URL: 
https://github.com/apache/rocketmq-client-cpp/pull/273#discussion_r393487302
 
 

 ##########
 File path: src/include/DefaultMQClient.h
 ##########
 @@ -187,6 +192,8 @@ class DefaultMQClient {
   std::string m_instanceName;
   std::string m_nameSpace;
   std::string m_GroupName;
+  std::string m_sslPropertyFile { DEFAULT_SSL_PROPERTY_FILE };
+  bool m_enableSsl { true };
 
 Review comment:
   IMO， it is better to keep ssl disabled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services